fix: language pack code unification#558
Conversation
|
@SQLGate Are you a Korean developer? We are glad to see the PR to Molecule, we are going to merge after review. |
… into feat/lanuage-pack
… into feat/lanuage-pack
Yes! I am Korean developer and Delphi developer. This project is the one I've been looking for. |
Co-authored-by: Ziv <wewoor@gmail.com>
… into feat/lanuage-pack
|
@SQLGate Unit tests failed, there need you to update the snapshots. |
|
If you have any questions, we also can communicate on Discord: https://discord.com/invite/b62gpHwNA7 |
|
How can i unit test it? |
At the root path, run |
Codecov Report
@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 86.77% 86.77%
=======================================
Files 189 189
Lines 5571 5572 +1
Branches 1245 1245
=======================================
+ Hits 4834 4835 +1
Misses 727 727
Partials 10 10
Continue to review full report at Codecov.
|
|
@SQLGate Maybe we need to extract the locales into an isolated package in the future. |
Description
Added Korean language pack.
Also, we have organized the Simplified Chinese and English language packs consistently.