Skip to content

fix: language pack code unification#558

Merged
wewoor merged 8 commits intoDTStack:mainfrom
SQLGate:feat/lanuage-pack
Dec 23, 2021
Merged

fix: language pack code unification#558
wewoor merged 8 commits intoDTStack:mainfrom
SQLGate:feat/lanuage-pack

Conversation

@SQLGate
Copy link
Copy Markdown
Collaborator

@SQLGate SQLGate commented Dec 21, 2021

Description

Added Korean language pack.
Also, we have organized the Simplified Chinese and English language packs consistently.

@wewoor wewoor added the enhancement New feature or request label Dec 21, 2021
@wewoor wewoor added this to the 0.9.0-beta.2 milestone Dec 21, 2021
@wewoor wewoor requested review from mortalYoung and wewoor December 21, 2021 06:29
@wewoor
Copy link
Copy Markdown
Collaborator

wewoor commented Dec 21, 2021

@SQLGate Are you a Korean developer? We are glad to see the PR to Molecule, we are going to merge after review.

Comment thread src/extensions/locales-defaults/locales/en.json Outdated
@SQLGate
Copy link
Copy Markdown
Collaborator Author

SQLGate commented Dec 21, 2021

@SQLGate Are you a Korean developer? We are glad to see the PR to Molecule, we are going to merge after review.

Yes! I am Korean developer and Delphi developer. This project is the one I've been looking for.
I'm making a database solution called SQLGate
http://www.sqlgate.com
and trying to get this product to work on the web.
So I was looking for an IDE JavaScript framework and I was grateful to see this source.

Copy link
Copy Markdown
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor
Copy link
Copy Markdown
Collaborator

wewoor commented Dec 21, 2021

@SQLGate Unit tests failed, there need you to update the snapshots.

@SQLGate
Copy link
Copy Markdown
Collaborator Author

SQLGate commented Dec 21, 2021

@SQLGate Unit tests failed, there need you to update the snapshots.
I will Unit tests, Again check code

@SQLGate SQLGate closed this Dec 21, 2021
@wewoor
Copy link
Copy Markdown
Collaborator

wewoor commented Dec 22, 2021

@SQLGate Unit tests failed, there need you to update the snapshots.
I will Unit tests, Again check code

If you have any questions, we also can communicate on Discord: https://discord.com/invite/b62gpHwNA7

@SQLGate
Copy link
Copy Markdown
Collaborator Author

SQLGate commented Dec 22, 2021

How can i unit test it?

@SQLGate SQLGate reopened this Dec 22, 2021
@wewoor
Copy link
Copy Markdown
Collaborator

wewoor commented Dec 22, 2021

How can i unit test it?

At the root path, run yarn test -u command

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 23, 2021

Codecov Report

Merging #558 (232db82) into main (2d89f56) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files         189      189           
  Lines        5571     5572    +1     
  Branches     1245     1245           
=======================================
+ Hits         4834     4835    +1     
  Misses        727      727           
  Partials       10       10           
Impacted Files Coverage Δ
src/extensions/locales-defaults/index.ts 90.00% <100.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d89f56...232db82. Read the comment docs.

@wewoor
Copy link
Copy Markdown
Collaborator

wewoor commented Dec 23, 2021

@SQLGate Maybe we need to extract the locales into an isolated package in the future.

@wewoor wewoor merged commit b9f817d into DTStack:main Dec 23, 2021
@wewoor wewoor mentioned this pull request Dec 28, 2021
11 tasks
@wewoor wewoor mentioned this pull request Jan 7, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants